Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme files for moved keyboards #14784

Closed
wants to merge 3 commits into from

Conversation

peepeetee
Copy link
Contributor

Update readmes to reflect #12159 's changes, this one is a continuation of #14172

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@peepeetee
Copy link
Contributor Author

peepeetee commented Oct 11, 2021

@colinta I changed your readme for xd75(again, this time it's probably going to make it in). It's pretty substantial and is quite custom, please check to see if I did everything right

People mentioned below, I've also changed your readmes, post any suggestions and objections in the comments

@zvecr @gabustoledo @Signynt @stevexyz @Deadolus @ajp10304 @cockpit @Waples @jos @birkir @edulpn @fvolpe83 @KMontag42 @krusli @melka @petesmom @semicolonsnet @Styr @supercoffee @yuuki @bbaserdem @buzzlighter1 @clanghans @lebastaq @ScheiklP @tdl-jturner

@zvecr zvecr changed the base branch from master to develop October 11, 2021 05:13
@zvecr
Copy link
Member

zvecr commented Oct 11, 2021

Im going to assume getting user sign off from everyone is unlikely so have changed the target to develop. If all users do, then this can go via master.

@Signynt
Copy link

Signynt commented Oct 11, 2021

Looks good, thanks for updating it, I oversaw that the line was outdated!

@clanghans
Copy link
Contributor

clanghans commented Oct 11, 2021

Im going to assume getting user sign off from everyone is unlikely so have changed the target to develop. If all users do, then this can go via master.

fine with me, thanks for the change.

@edulpn
Copy link
Contributor

edulpn commented Oct 11, 2021 via email

@gabustoledo
Copy link

its ok, thanks for update

@bbaserdem
Copy link
Contributor

In my updated fork (which is waiting review) i removed the readme file since i don't use this board anymore. If this gets on master; it is going to mess up my pull request I assume.

@KMontag42
Copy link
Contributor

LGTM 👍

@drashna drashna requested a review from a team November 7, 2021 16:42
@peepeetee peepeetee closed this Nov 10, 2021
peepeetee added a commit to peepeetee/qmk_firmware that referenced this pull request Nov 10, 2021
@peepeetee
Copy link
Contributor Author

For the records, this got merged into #15047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants